Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restic Backup: Add check if Pod is successful or failed for emptyDir.… #3993

Merged
merged 2 commits into from
Aug 4, 2021
Merged

Conversation

mahaupt
Copy link
Contributor

@mahaupt mahaupt commented Jul 27, 2021

Summary

I added a check to exclude restic backups for emptyDirs on stopped but unremoved pods (successful / failed).
Emptydirs are only guaranteed to persist on running / crashing pods.

https://kubernetes.io/docs/concepts/storage/volumes/#emptydir

https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/#pod-phase

Please let me know if I shall add a changelog / documentation for this small bugfix.

Does your change fix a particular issue?

Fixes #3812

Please indicate you've done the following:

…ix #3812

Signed-off-by: mahaupt <marcel.haupt@gepardec.com>
Copy link
Collaborator

@sseago sseago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but since it's a bug fix, it will need a changelog file.

Signed-off-by: mahaupt <marcel.haupt@gepardec.com>
@mahaupt
Copy link
Contributor Author

mahaupt commented Jul 28, 2021

I just added the missing changelog file

@mahaupt mahaupt requested a review from sseago July 28, 2021 07:31
@jenting jenting merged commit 7cb6147 into vmware-tanzu:main Aug 4, 2021
gyaozhou pushed a commit to gyaozhou/velero-read that referenced this pull request May 14, 2022
vmware-tanzu#3993)

* Restic Backup: Add check if Pod is successful or failed for emptyDir. Fix vmware-tanzu#3812
* Add changelog

Signed-off-by: mahaupt <marcel.haupt@gepardec.com>
@Ankita5892
Copy link

Ankita5892 commented Jul 11, 2022

my pods are running for openshift all namespace still its give issue for only pod's which has emptyDir its not failing but its stuck like never ending backup
any one has idea, i have raised new issue

#5113

@mahaupt
Copy link
Contributor Author

mahaupt commented Jul 11, 2022

Check if the velero pod has enough resources and is not running out of memory

@Ankita5892
Copy link

Ankita5892 commented Jul 11, 2022

yes restic memory limit is 2gi and request 500mi while installing i am passing

--velero-pod-cpu-limit 1500m --velero-pod-cpu-request 700m --velero-pod-mem-limit 2Gi --velero-pod-mem-request 500Mi --restic-pod-cpu-limit 1500m --restic-pod-cpu-request 500m --restic-pod-mem-limit 2Gi --restic-pod-mem-request 500Mi --default-volumes-to-restic

see full logs #5113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Partially failed backups when trying to backup empty emptyDir with restic
4 participants